Jump to content
Main menu
Main menu
move to sidebar
hide
Navigation
Main page
Recent changes
Random page
Help about MediaWiki
Special pages
ANRC Universe
Search
Search
Appearance
Create account
Log in
Personal tools
Create account
Log in
Pages for logged out editors
learn more
Contributions
Talk
Editing
Module talk:TableTools
(section)
Add topic
Module
Discussion
English
Read
Edit
View history
Tools
Tools
move to sidebar
hide
Actions
Read
Edit
Add topic
View history
General
What links here
Related changes
Page information
Appearance
move to sidebar
hide
Warning:
You are not logged in. Your IP address will be publicly visible if you make any edits. If you
log in
or
create an account
, your edits will be attributed to your username, along with other benefits.
Anti-spam check. Do
not
fill this in!
== Edit request 23 April 2024 == {{Edit fully-protected|answered=yes}} This request is to implement all the changes made to the sandbox until this time. The differences can be checked with [https://en.wikipedia.org/w/index.php?title=Module%3ATableTools%2Fsandbox&diff=1220306247&oldid=1068321711 this diff link]. Notably, I added the <code>merge</code> and <code>extend</code> functions for arrays. Pretty sure such functions are standard in any language that has array-like objects. Therefore, I found it appropriate to make them available here since Scribunto apparently didn't port them from base Lua. [[User:Alexiscoutinho|Alexis Coutinho]] ([[User talk:Alexiscoutinho|talk]]) <sup>[''[[WP:PING|ping me]]'']</sup> 00:07, 23 April 2024 (UTC) :Guess I should add test cases. [[User:Alexiscoutinho|Alexis Coutinho]] ([[User talk:Alexiscoutinho|talk]]) <sup>[''[[WP:PING|ping me]]'']</sup> 18:13, 24 April 2024 (UTC) ::@[[User:Alexiscoutinho|Alexiscoutinho]] I don't really see any benefit from throwing an error if <code>merge</code> only receives 1 argument; it's plausible that a module might want to merge an arbitrary number of arrays based on user input, and all this restriction does is push the check for 1 argument onto the calling module. It's the same reason you can call (e.g.) {{code|math.min()|lua}} or {{code|math.max()|lua}} with only 1 argument, despite that being pointless in many situations. [[User:Theknightwho|Theknightwho]] ([[User talk:Theknightwho|talk]]) 00:30, 25 April 2024 (UTC) :::π [[User:Alexiscoutinho|Alexis Coutinho]] ([[User talk:Alexiscoutinho|talk]]) <sup>[''[[WP:PING|ping me]]'']</sup> 01:14, 25 April 2024 (UTC) :::{{done}}. But I wonder if a check should exist to verify if the inputs form a sequence (i.e. not sparse table)... [[User:Alexiscoutinho|Alexis Coutinho]] ([[User talk:Alexiscoutinho|talk]]) <sup>[''[[WP:PING|ping me]]'']</sup> 07:09, 26 April 2024 (UTC) ::{{done}} aswell. This edit request is ready for review (and I guess {{u|Theknightwho}}'s changes too). [[User:Alexiscoutinho|Alexis Coutinho]] ([[User talk:Alexiscoutinho|talk]]) <sup>[''[[WP:PING|ping me]]'']</sup> 08:03, 26 April 2024 (UTC) : {{done|Copied}} over to live module. [[User:Pppery|* Pppery *]] [[User talk:Pppery|<sub style="color:#800000">it has begun...</sub>]] 01:49, 27 April 2024 (UTC) ::{{ty}}. [[User:Alexiscoutinho|Alexis Coutinho]] ([[User talk:Alexiscoutinho|talk]]) <sup>[''[[WP:PING|ping me]]'']</sup> 06:07, 27 April 2024 (UTC)
Summary:
Please note that all contributions to ANRC Universe may be edited, altered, or removed by other contributors. If you do not want your writing to be edited mercilessly, then do not submit it here.
You are also promising us that you wrote this yourself, or copied it from a public domain or similar free resource (see
ANRC Universe:Copyrights
for details).
Do not submit copyrighted work without permission!
Cancel
Editing help
(opens in new window)
Search
Search
Editing
Module talk:TableTools
(section)
Add topic