Editing Module talk:TableTools (section)

== Potential code simplification ==

Keeping in mind that I don't actually know much about Lua and could easily be overlooking some obvious problem with this suggestion, the functions <code>isPositiveInteger()</code> and <code>isNan()</code> could be slightly simplified by removing the <code>if</code> structures and instead directly returning on the logic, since it should return <code>true</code> or <code>false</code>, as appropriate, already. I'd demonstrate exactly what I mean in the sandbox, but there are other outstanding changes there and I didn't want to introduce irrelevant changes without approval first. <span class=nowrap>「[[User:Dinoguy1000|<span style=color:#00f>ディノ</span><span style=color:#080>奴</span>]][[Special:Contributions/Dinoguy1000|<span style=color:#F90>千？！</span>]]」<sup>[[User talk:Dinoguy1000#top|☎ Dinoguy1000]]</sup></span> 02:15, 31 October 2019 (UTC)
: {{ping|Dinoguy1000}} As the user who coded the changes currently in the sandbox, feel free to demonstrate your simplification edit. [[User:Pppery|* Pppery *]] [[User talk:Pppery|<sub style="color:#800000">it has begun...</sub>]] 23:43, 4 November 2019 (UTC)
::[https://en.wikipedia.org/w/index.php?title=Module:TableTools/sandbox&diff=924665819&oldid=923649632 Done]. Promisingly, all [[Module talk:TableTools/testcases|testcases]] appear to be passing after this, assuming I'm understanding that page correctly. <span class=nowrap>「[[User:Dinoguy1000|<span style=color:#00f>ディノ</span><span style=color:#080>奴</span>]][[Special:Contributions/Dinoguy1000|<span style=color:#F90>千？！</span>]]」<sup>[[User talk:Dinoguy1000#top|☎ Dinoguy1000]]</sup></span> 05:38, 5 November 2019 (UTC)
::: {{ping|Dinoguy1000}} Looks like an improvement to me, which I will include if I stop worrying too much about editing a module with this many transclusions and actually implement the TfD I initiated in February. [[User:Pppery|* Pppery *]] [[User talk:Pppery|<sub style="color:#800000">it has begun...</sub>]] 01:59, 8 November 2019 (UTC)
::::{{ping|Pppery}} I think a similar improvement can be made in the <code>cleanPattern()</code> subroutine of the <code>affixNums()</code> function, though I'm not sure (again, I don't know enough about Lua or Scribunto to know if there might be some gotcha there), in the event you want to look at another thing to bundle into the edit too. <span class=nowrap>「[[User:Dinoguy1000|<span style=color:#00f>ディノ</span><span style=color:#080>奴</span>]][[Special:Contributions/Dinoguy1000|<span style=color:#F90>千？！</span>]]」<sup>[[User talk:Dinoguy1000#top|☎ Dinoguy1000]]</sup></span> 03:56, 8 November 2019 (UTC)